Discussion:
binkd 1.0a-605/OS2
(too old to reply)
Max Vasilyev
2012-02-16 15:41:42 UTC
Permalink
Hello Andre!

16 Feb 12 14:09, you wrote to me:

AG> And this is really with the same settings?
yes - the only difference is perl-hooks

WBR, Max. piwamoto!писем-нет
Andre Grueneberg
2012-02-18 13:46:04 UTC
Permalink
Hi Max
Post by Max Vasilyev
AG> And this is really with the same settings?
yes - the only difference is perl-hooks
I finally managed to setup a Win32 build environment with Perl -- I tried to
use the Perl in Cygwin for quite some time. After installing Strawberry Perl, I
finally managed to get the build running.

It turns out that perl_parse() screws up the original environment despite
getting a copy passed to it. The perlembed documentation is a bit vague about
it, but it explicitly mentions to pass NULL as environment pointer. Some
versions of Perl seem to clear environ[0] if they get passed another
environment.

I have corrected this now, as well as a Win32 compilation issue in FSP1035
support. Revision -607 is available in CVS. Feel free to test.

CU Andre E-Mail: ***@grueneberg.de
Max Vasilyev
2012-02-20 13:44:30 UTC
Permalink
Hello Andre!

18 Feb 12 17:46, you wrote to me:

AG> I have corrected this now, as well as a Win32 compilation issue in
AG> FSP1035 support. Revision -607 is available in CVS. Feel free to test.
at least binkd/win32 works

WBR, Max. piwamoto!писем-нет
Andrew Leary
2012-02-20 06:06:10 UTC
Permalink
Hello Max!

Monday February 20 2012 17:44, Max Vasilyev wrote to Andre Grueneberg:

AG>> I have corrected this now, as well as a Win32 compilation issue
AG>> in FSP1035 support. Revision -607 is available in CVS. Feel free
AG>> to test.
MV> at least binkd/win32 works

I just tested your OS/2 compile of -607, and it works correctly as well.

Regards,

Andrew
mark lewis
2012-02-21 08:25:35 UTC
Permalink
AG>> I have corrected this now, as well as a Win32 compilation issue
AG>> in FSP1035 support. Revision -607 is available in CVS. Feel free
AG>> to test.
MV> at least binkd/win32 works

AL> I just tested your OS/2 compile of -607, and it works correctly as
AL> well.

would you mind dropping that in my inbound? i don't yet know what it may bring
in the way of fixes as compared to what i'm running and i don't need the perl
feature at all but i guess it would be better to be up to date... hopefully it
will run alright on my OS/2 Warp 3 Connect...

)\/(ark
Andrew Leary
2012-02-21 15:12:37 UTC
Permalink
Hello mark!

Tuesday February 21 2012 12:25, mark lewis wrote to Andrew Leary:

AL>> I just tested your OS/2 compile of -607, and it works correctly
AL>> as well.

ml> would you mind dropping that in my inbound? i don't yet know what it
ml> may bring in the way of fixes as compared to what i'm running and i
ml> don't need the perl feature at all but i guess it would be better to
ml> be up to date... hopefully it will run alright on my OS/2 Warp 3
ml> Connect...

Look for binkd-1.0a-607-os2emx-zlib-bzlib2-perl.zip in your inbound. You may
need to increase SHELLHANDLESINC in your CONFIG.SYS if you connect to someone
with lots of addresses, as the newer versions of BinkD keep the .BSY files open
during the session.

Regards,

Andrew
mark lewis
2012-02-22 06:54:47 UTC
Permalink
AL>> I just tested your OS/2 compile of -607, and it works correctly
AL>> as well.

ml> would you mind dropping that in my inbound? i don't yet know what it
ml> may bring in the way of fixes as compared to what i'm running and i
ml> don't need the perl feature at all but i guess it would be better to
ml> be up to date... hopefully it will run alright on my OS/2 Warp 3
ml> Connect...

AL> Look for binkd-1.0a-607-os2emx-zlib-bzlib2-perl.zip in your
AL> inbound.

i shall take a look... thanks!

AL> You may need to increase SHELLHANDLESINC in your CONFIG.SYS

i do not believe that this is a valid verb for my old OS... but we shall see ;)

AL> if you connect to someone with lots of addresses, as the
AL> newer versions of BinkD keep the .BSY files open during the
AL> session.

hummm... wonder why that change? their simple existance should denote that the
system is busy with that remote...

)\/(ark
Andre Grueneberg
2012-02-22 14:24:16 UTC
Permalink
Hi mark

mark lewis schrieb:

AL>> if you connect to someone with lots of addresses, as the
AL>> newer versions of BinkD keep the .BSY files open during the
AL>> session.
ml> hummm... wonder why that change? their simple existance should
ml> denote that the system is busy with that remote...

From what I can see the busy files are being updated regularly. I do not fully
understand the objective behind it either. I suspect some tossers might
otherwise belive these are stale bsy files?!

This does not necessarily require the files to be kept open ... but that's the
code in place.

CU Andre E-Mail: ***@grueneberg.de
mark lewis
2012-02-22 10:25:15 UTC
Permalink
AL>> if you connect to someone with lots of addresses, as the
AL>> newer versions of BinkD keep the .BSY files open during the
AL>> session.
ml> hummm... wonder why that change? their simple existance should
ml> denote that the system is busy with that remote...

AG> From what I can see the busy files are being updated regularly. I
AG> do not fully understand the objective behind it either. I suspect
AG> some tossers might otherwise belive these are stale bsy files?!

interesting theory... can you go back thru the commits and see when it was
introduced and then query as to why? if there are tossers thinking such, it
would be good to know which ones and if they have been repaired yet ;)

AG> This does not necessarily require the files to be kept open ... but
AG> that's the code in place.

understood :)

)\/(ark
Andre Grueneberg
2012-02-22 19:30:34 UTC
Permalink
Hi mark

mark lewis schrieb:

AG>> From what I can see the busy files are being updated regularly. I
AG>> do not fully understand the objective behind it either. I suspect
AG>> some tossers might otherwise belive these are stale bsy files?!
ml> interesting theory... can you go back thru the commits and see when
ml> it was introduced and then query as to why? if there are tossers
ml> thinking such, it would be good to know which ones and if they have
ml> been repaired yet ;)

I can do it as much as you or anyone else can. ;)
https://github.com/green525/binkd/commits/master/bsy.c

As you can see, it's in there at least since 2001 -- if I'm not totally
mistaken.

CU Andre E-Mail: ***@grueneberg.de
mark lewis
2012-02-23 06:55:03 UTC
Permalink
ml> interesting theory... can you go back thru the commits and see when
ml> it was introduced and then query as to why? if there are tossers
ml> thinking such, it would be good to know which ones and if they have
ml> been repaired yet ;)

AG> I can do it as much as you or anyone else can. ;)
AG> https://github.com/green525/binkd/commits/master/bsy.c

sorry, i have never done anything with any type of source control system... not
until about a week or two ago and i'm still not using it though i have tried :?

AG> As you can see, it's in there at least since 2001 -- if I'm not
AG> totally mistaken.

what i see is that the initial revision and evidently a "cross pull" or update
from CVS was done Jan 10, 2001... other than that, the code means nothing to
me... i don't do C or C++ unless extremely hardpressed to dig into it :?

in either case, there's not enough information... at least nothing indicating
who made the change other than "gul" whoever that is... and nothing, as in a
comment, indicating where the change is or why it was made :?

)\/(ark
Andre Grueneberg
2012-02-23 15:17:56 UTC
Permalink
Hi mark

mark lewis schrieb:

AG>> I can do it as much as you or anyone else can. ;)
AG>> https://github.com/green525/binkd/commits/master/bsy.c
ml> sorry, i have never done anything with any type of source control
ml> system... not until about a week or two ago and i'm still not using
ml> it though i have tried :?

Okay ... I didn't know. ;)

ml> in either case, there's not enough information... at least nothing
ml> indicating who made the change other than "gul" whoever that is...

gul is Pavel Gulchouk.

ml> and nothing, as in a comment, indicating where the change is or why
ml> it was made :?

... the list contains buttons for "Browse code" as well as the commit ID.
Clicking on the latter shows a patch/diff of this commit, automatically jumping
to the file in question.

CU Andre E-Mail: ***@grueneberg.de

Loading...